upgrade jobs to v31 - drop v29 support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied latest https://github.com/nextcloud/.github in order to avoid hardcoded stable* branches Signed-off-by: Misha M.-Kupriyanov <[email protected]>
drop v29 support Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
18 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Nextcloud OCP dependencies to v31 and removes support for v29, while modernizing GitHub Actions workflows across the repository.
- Bumps
nextcloud/ocpdev dependency to v31.0.6 and updates app metadata to drop v29 support. - Updates all CI workflows with current action versions, SPDX headers, permissions, and optimized matrix strategies.
- Adds PHP version enforcement checks in Psalm and refines dependency installation steps in workflows.
Reviewed Changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/AppInfo/Application.php | Added blank line to improve license header formatting |
| composer.json | Bumped development dependency nextcloud/ocp to v31.0.6 |
| appinfo/info.xml | Updated <nextcloud> min-version from 29 to 30 (dropped v29 support) |
| .github/workflows/update-nextcloud-ocp-matrix.yml | Upgraded checkout & setup-php actions, switched matrix to default branch |
| .github/workflows/update-nextcloud-ocp-approve-merge.yml | Added fork guard, bumped action versions, updated runs-on |
| .github/workflows/psalm-matrix.yml | Added SPDX header, bumped action versions, enforced PHP version in psalm |
| .github/workflows/phpunit-sqlite.yml | Modernized template, added file-existence checks, updated action versions |
| .github/workflows/phpunit-mysql.yml | Similar modernization for MySQL workflow with matrix and checks |
| .github/workflows/lint-php.yml | Updated checkout & setup-php steps, standardized runs-on |
| .github/workflows/lint-php-cs.yml | Updated checkout & setup-php steps with persist-credentials |
| .github/workflows/lint-info-xml.yml | Updated checkout step and SPDX header |
| .github/workflows/fixup.yml | Bumped action version, updated runs-on |
| .github/workflows/block-unconventional-commits.yml | Bumped action version, updated runs-on |
Comments suppressed due to low confidence (2)
.github/workflows/psalm-matrix.yml:36
- The grep pattern lacks a closing double quote and may not match the full
phpVersionattribute; update to include the trailing", for examplegrep 'phpVersion="${{ steps.versions.outputs.php-min }}"' psalm.xml.
run: grep 'phpVersion="${{ steps.versions.outputs.php-min }}' psalm.xml
appinfo/info.xml:14
- [nitpick] The app metadata still allows Nextcloud 30 despite the dev dependency being bumped to OCP v31 only; consider aligning
min-versionto 31 or adjust the dependency requirement to include v30 if backward compatibility is intended.
<nextcloud min-version="30" max-version="31"/>
printminion-co
force-pushed
the
mk/dev/upgrade_jobs_to_v31
branch
from
f494cc2 to
ad5f185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.